Repository navigation
Update getSigAlgs to handle algorithms without combined NID - #1019
Open
eager-signal wants to merge 1 commit into
Open
eager-signal wants to merge 1 commit into
eager-signal wants to merge 1 commit into
Conversation
Author
|
I‘m not sure if the duplicated/indistinguishable |
Member
|
@davidben WDYT ? |
Motivation: Some algorithms, such as Ed25519, have no combined signature and hash NID, causing them to be returned as NID_undef, and thus unusable to callers. Modifications: Fall back to `psign` if `psignhash` is undefined Result: | Code point | TLS name | Before | After | |------------|-----------------------|-------------|-----------------| | `0x0807` | `ed25519` | `undefined` | `ED25519` | | `0x0808` | `ed448` | `undefined` | `ED448` | | `0x0804` | `rsa_pss_rsae_sha256` | `undefined` | `rsassaPss` | | `0x0805` | `rsa_pss_rsae_sha384` | `undefined` | `rsassaPss` | | `0x0806` | `rsa_pss_rsae_sha512` | `undefined` | `rsassaPss` | | `0x0809` | `rsa_pss_pss_sha256` | `undefined` | `rsassaPss` | | `0x080a` | `rsa_pss_pss_sha384` | `undefined` | `rsassaPss` | | `0x080b` | `rsa_pss_pss_sha512` | `undefined` | `rsassaPss` | | `0x0302` | `dsa_sha224` | `undefined` | `dsaEncryption` | | `0x0502` | `dsa_sha384` | `undefined` | `dsaEncryption` | | `0x0602` | `dsa_sha512` | `undefined` | `dsaEncryption` |
eager-signal
force-pushed
the
sigalgs-ed25519
branch
from
October 1, 2026 15:30
78a626c to
071bc6e
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Some algorithms, such as Ed25519, have no combined signature and hash NID, causing them to be returned as NID_undef, and thus unusable to callers.
Modifications:
Fall back to
psignifpsignhashis undefinedResult:
0x0807ed25519undefinedED255190x0808ed448undefinedED4480x0804rsa_pss_rsae_sha256undefinedrsassaPss0x0805rsa_pss_rsae_sha384undefinedrsassaPss0x0806rsa_pss_rsae_sha512undefinedrsassaPss0x0809rsa_pss_pss_sha256undefinedrsassaPss0x080arsa_pss_pss_sha384undefinedrsassaPss0x080brsa_pss_pss_sha512undefinedrsassaPss0x0302dsa_sha224undefineddsaEncryption0x0502dsa_sha384undefineddsaEncryption0x0602dsa_sha512undefineddsaEncryption